Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1704768

[PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id.
Date 2017-08-06 09:20 +0200
Message-ID <ubo0W-7Da-5@gated-at.bofh.it> (permalink)
References <ubnRg-7zP-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/video/fbdev/udlfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 05ef657..d836e6e 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -54,7 +54,7 @@ static const u32 udlfb_info_flags = FBINFO_DEFAULT | FBINFO_READS_FAST |
  * which is compatible with all known USB 2.0 era graphics chips and firmware,
  * but allows DisplayLink to increment those for any future incompatible chips
  */
-static struct usb_device_id id_table[] = {
+static const struct usb_device_id id_table[] = {
 	{.idVendor = 0x17e9,
 	 .bInterfaceClass = 0xff,
 	 .bInterfaceSubClass = 0x00,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:10 +0200
  [PATCH 1/2] video: fbdev: smscufx: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:20 +0200
  [PATCH 2/2] video: fbdev: udlfb: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:20 +0200

csiph-web