Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code

Path	csiph.com!goblin1!goblin.stu.neva.ru!news.panservice.it!bofh.it!news.nic.it!robomod
From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code
Date	Sat, 05 Aug 2017 22:20:01 +0200
Message-ID	<ubdId-1aY-7@gated-at.bofh.it> (permalink)
References	<uaTgu-4xE-9@gated-at.bofh.it> <uaTgu-4xE-15@gated-at.bofh.it> <uaVBD-5XD-7@gated-at.bofh.it>
X-Original-To	Andrew Lunn <andrew@lunn.ch>
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" <davem@davemloft.net>, Florian Fainelli <f.fainelli@gmail.com>
X-Original-Date	Sat, 05 Aug 2017 16:09:28 -0400
X-Original-Message-ID	<873795g4jr.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
X-Original-References	<20170804222320.10986-1-vivien.didelot@savoirfairelinux.com> <20170804222320.10986-2-vivien.didelot@savoirfairelinux.com> <20170805005526.GA19193@lunn.ch>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1704701

Show key headers only | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct net_device *master,
>>  	ds->cd = cd;
>>  	ds->ops = ops;
>>  	ds->priv = priv;
>> +	ds->dev = parent;
>
> Is this even needed? dsa_switch_alloc() does ds->dev = dev.

You are correct! Respinning.


Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/3] net: dsa: assign switch device in legacy code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-05 00:30 +0200
  Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy  code Andrew Lunn <andrew@lunn.ch> - 2017-08-05 03:00 +0200
    Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-05 22:20 +0200

csiph-web