Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704531

Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code
Date 2017-08-05 03:00 +0200
Message-ID <uaVBD-5XD-7@gated-at.bofh.it> (permalink)
References <uaTgu-4xE-9@gated-at.bofh.it> <uaTgu-4xE-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct net_device *master,
>  	ds->cd = cd;
>  	ds->ops = ops;
>  	ds->priv = priv;
> +	ds->dev = parent;

Hi Vivien

Is this even needed? dsa_switch_alloc() does ds->dev = dev.

   Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/3] net: dsa: assign switch device in legacy code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-05 00:30 +0200
  Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy  code Andrew Lunn <andrew@lunn.ch> - 2017-08-05 03:00 +0200
    Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-05 22:20 +0200

csiph-web