Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705764

Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk()

Show all headers | View raw

On Sat, 2017-08-05 at 07:16 +0200, Borislav Petkov wrote:
> On Fri, Aug 04, 2017 at 09:02:17PM +0000, Kani, Toshimitsu wrote:
> > GHES platform devices correspond to GHES entries, which define
> > firmware interfaces to report generic memory errors to the OS, such
> > as NMI and SCI.  These devices are associated with all DIMMs, not a
> > particular DIMM.
> 
> And? Stating the obvious brings you what exactly?
> 
> IOW, you still haven't answered my question.

Sorry about that.  Let me copy your original comments to make sure I
answer your questions this time.

> So the problem is that ghes_edac_register() gets called multiple
> times depending on how many GHES platform devices are on the system.
> But yet they all scan *all* DIMMs. 

Right, and this patch changes ghes_edac_register() to scan all DIMMs at
the first time and do not scan them next times.

> So instead you should return if
> the DIMMs have been counted already and not register a second time.
> Which makes that whole mc counting kinda useless. So you could rip
>
that out too.

Oh, I see.  So, ghes_edac_register() should return no-op a second time,
and does not call edac_mc_add_mc() to register with a separate mci.

I think we should keep the current scheme, which registers an mci for
each GHES entry.  ghes_edac_report_mem_error() expects that error-
reporting is serialized per a GHES entry.  Sharing a single mci among
all GHES entries / error interfaces might lead to a race condition.

Thanks,
-Toshi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] enable ghes_edac on selected platforms Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
  [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
      Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 22:40 +0200
        Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
          Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist()  interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 16:50 +0200
  [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-04 06:10 +0200
      Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
        Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
          Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 20:00 +0200
            Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-11 11:10 +0200
  [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
      Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:40 +0200
        Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-05 07:50 +0200
          Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
    Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner kbuild test robot <lkp@intel.com> - 2017-08-04 15:10 +0200
      Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 17:30 +0200
  [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
      Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
        Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:40 +0200
          Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
  [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
    Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
      Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:00 +0200
        Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
          Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
  [PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200

csiph-web