Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703628
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface |
| Date | 2017-08-04 05:50 +0200 |
| Message-ID | <uaBMB-1A5-3@gated-at.bofh.it> (permalink) |
| References | <uawtz-6iB-3@gated-at.bofh.it> <uawtz-6iB-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 03, 2017 at 03:57:47PM -0600, Toshi Kani wrote:
> ACPI OEM ID / OEM Table ID / Revision can be used to identify
> a platform based on ACPI firmware info. acpi_blacklisted(),
> intel_pstate_platform_pwr_mgmt_exists(), and some other funcs,
> have been using similar check to detect a list of platforms
> that require special handlings.
>
> Move the platform check in acpi_blacklisted() to a new common
> utility function, acpi_match_oemlist(), so that other drivers
> do not have to implement their own version.
>
> There is no change in functionality.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Borislav Petkov <bp@alien8.de>
> ---
> drivers/acpi/blacklist.c | 83 ++++++++--------------------------------------
> drivers/acpi/utils.c | 40 ++++++++++++++++++++++
> include/linux/acpi.h | 19 +++++++++++
> 3 files changed, 73 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index bb542ac..bf44573 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -30,30 +30,13 @@
>
> #include "internal.h"
>
> -enum acpi_blacklist_predicates {
> - all_versions,
> - less_than_or_equal,
> - equal,
> - greater_than_or_equal,
> -};
> -
> -struct acpi_blacklist_item {
> - char oem_id[7];
> - char oem_table_id[9];
> - u32 oem_revision;
> - char *table;
> - enum acpi_blacklist_predicates oem_revision_predicate;
> - char *reason;
> - u32 is_critical_error;
> -};
> -
> static struct dmi_system_id acpi_rev_dmi_table[] __initdata;
>
> /*
> * POLICY: If *anything* doesn't work, put it on the blacklist.
> * If they are critical errors, mark it critical, and abort driver load.
> */
> -static struct acpi_blacklist_item acpi_blacklist[] __initdata = {
> +static struct acpi_oemlist acpi_blacklist[] __initdata = {
All that wasted energy to try to explain to you that "oemlist" is wrong
and that whole rename is pointless, went for nothing.
So NAK.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/7] enable ghes_edac on selected platforms Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
[PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 22:40 +0200
Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
Re: [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 16:50 +0200
[PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-04 06:10 +0200
Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 20:00 +0200
Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov <bp@alien8.de> - 2017-08-11 11:10 +0200
[PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:40 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov <bp@alien8.de> - 2017-08-05 07:50 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner kbuild test robot <lkp@intel.com> - 2017-08-04 15:10 +0200
Re: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 17:30 +0200
[PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 10:40 +0200
Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:10 +0200
Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:40 +0200
Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
[PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-04 05:50 +0200
Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-04 23:00 +0200
Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-05 07:20 +0200
Re: [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-07 17:00 +0200
[PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani <toshi.kani@hpe.com> - 2017-08-04 00:10 +0200
csiph-web