Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1705481

[PATCH 5/5] block-skd: Use ARRAY_SIZE() in skd_check_status()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 5/5] block-skd: Use ARRAY_SIZE() in skd_check_status()
Date 2017-08-07 15:10 +0200
Message-ID <ubPXc-bV-23@gated-at.bofh.it> (permalink)
References <ubPNx-8kD-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 7 Aug 2017 14:34:33 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: Prefer ARRAY_SIZE(skd_chkstat_table)

Thus use this macro.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/block/skd_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index e53b40341834..555cf4810409 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2272,7 +2272,7 @@ skd_check_status(struct skd_device *skdev,
 		 skerr->key, skerr->code, skerr->qual, skerr->fruc);
 
 	/* Does the info match an entry in the good category? */
-	n = sizeof(skd_chkstat_table) / sizeof(skd_chkstat_table[0]);
+	n = ARRAY_SIZE(skd_chkstat_table);
 	for (i = 0; i < n; i++) {
 		struct sns_info *sns = &skd_chkstat_table[i];
 
-- 
2.13.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] block-skd: Adjustments for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:00 +0200
  [PATCH 1/5] block-skd: Delete an error message for a failed memory  allocation in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:00 +0200
  [PATCH 3/5] block-skd: Delete an unnecessary return statement in  skd_pci_remove() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 5/5] block-skd: Use ARRAY_SIZE() in skd_check_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 2/5] block-skd: Adjust 44 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 4/5] block-skd: Fix a typo in a comment line in  skd_do_inq_page_da() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200

csiph-web