Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1705480

[PATCH 3/5] block-skd: Delete an unnecessary return statement in skd_pci_remove()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 3/5] block-skd: Delete an unnecessary return statement in skd_pci_remove()
Date 2017-08-07 15:10 +0200
Message-ID <ubPXc-bV-19@gated-at.bofh.it> (permalink)
References <ubPNx-8kD-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 7 Aug 2017 14:10:35 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/block/skd_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index fa8569d4543b..8e2c89069927 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -4831,8 +4831,6 @@ static void skd_pci_remove(struct pci_dev *pdev)
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
 	pci_set_drvdata(pdev, NULL);
-
-	return;
 }
 
 static int skd_pci_suspend(struct pci_dev *pdev, pm_message_t state)
-- 
2.13.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] block-skd: Adjustments for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:00 +0200
  [PATCH 1/5] block-skd: Delete an error message for a failed memory  allocation in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:00 +0200
  [PATCH 3/5] block-skd: Delete an unnecessary return statement in  skd_pci_remove() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 5/5] block-skd: Use ARRAY_SIZE() in skd_check_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 2/5] block-skd: Adjust 44 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200
  [PATCH 4/5] block-skd: Fix a typo in a comment line in  skd_do_inq_page_da() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 15:10 +0200

csiph-web