Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1705204

[PATCH 2/2] dmaengine: at_xdmac: Handle return value of clk_prepare_enable.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/2] dmaengine: at_xdmac: Handle return value of clk_prepare_enable.
Date 2017-08-07 09:50 +0200
Message-ID <ubKXx-5k4-57@gated-at.bofh.it> (permalink)
References <ubKXv-5k4-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/dma/at_xdmac.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 6a3cf97..c00e392 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1883,8 +1883,11 @@ static int atmel_xdmac_resume(struct device *dev)
 	struct at_xdmac_chan	*atchan;
 	struct dma_chan		*chan, *_chan;
 	int			i;
+	int ret;
 
-	clk_prepare_enable(atxdmac->clk);
+	ret = clk_prepare_enable(atxdmac->clk);
+	if (ret)
+		return ret;
 
 	/* Clear pending interrupts. */
 	for (i = 0; i < atxdmac->dma.chancnt; i++) {
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] dmaengine: at_xdmac: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-07 09:50 +0200
  [PATCH 2/2] dmaengine: at_xdmac: Handle return value of clk_prepare_enable. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-07 09:50 +0200

csiph-web