Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705205

RE: [PATCH] qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'

Show all headers | View raw

> We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we
> check
> 'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'.
> 
> 'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines
> above in 'qed_load_mcp_offsets()'.
> 
> Update the test and check the result of the 2 'kzalloc()' instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks

Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-07 00:10 +0200
  RE: [PATCH] qed: Fix a memory allocation failure test in  'qed_mcp_cmd_init()' "Tayar, Tomer" <Tomer.Tayar@cavium.com> - 2017-08-07 09:50 +0200

csiph-web