Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1705202

[PATCH v2 5/6] edac: synopsys: Update ECC error message info

From Michal Simek <michal.simek@xilinx.com>
Newsgroups linux.kernel
Subject [PATCH v2 5/6] edac: synopsys: Update ECC error message info
Date 2017-08-07 09:50 +0200
Message-ID <ubKXx-5k4-53@gated-at.bofh.it> (permalink)
References <ubKNP-5gB-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>

This patch updates the ECC error message info
for zynqmp ddrc. added Block number and Bankgroup
in the message info.

Signed-off-by: Naga Sureshkumar Relli <nagasure@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- s/ecc/ECC/ in commit message

 drivers/edac/synopsys_edac.c | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 4cd9e3d8161c..24490334a4f2 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -418,9 +418,17 @@ static void synps_edac_handle_error(struct mem_ctl_info *mci,
 
 	if (p->ce_cnt) {
 		pinf = &p->ceinfo;
-		snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
-			 "DDR ECC error type :%s Row %d Bank %d Col %d ",
-			 "CE", pinf->row, pinf->bank, pinf->col);
+		if (priv->p_data->quirks == 0)
+			snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
+				 "DDR ECC error type :%s Row %d Bank %d Col %d ",
+				 "CE", pinf->row, pinf->bank, pinf->col);
+		else
+			snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
+				 "DDR ECC error type :%s Row %d Bank %d Col %d "
+				 "BankGroup Number %d Block Number %d",
+				 "CE", pinf->row, pinf->bank, pinf->col,
+				 pinf->bankgrpnr, pinf->blknr);
+
 		edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci,
 				     p->ce_cnt, 0, 0, 0, 0, 0, -1,
 				     priv->message, "");
@@ -428,9 +436,16 @@ static void synps_edac_handle_error(struct mem_ctl_info *mci,
 
 	if (p->ue_cnt) {
 		pinf = &p->ueinfo;
-		snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
-			 "DDR ECC error type :%s Row %d Bank %d Col %d ",
-			 "UE", pinf->row, pinf->bank, pinf->col);
+		if (priv->p_data->quirks == 0)
+			snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
+				 "DDR ECC error type :%s Row %d Bank %d Col %d ",
+				"UE", pinf->row, pinf->bank, pinf->col);
+		else
+			snprintf(priv->message, SYNPS_EDAC_MSG_SIZE,
+				 "DDR ECC error type :%s Row %d Bank %d Col %d "
+				 "BankGroup Number %d Block Number %d",
+				 "UE", pinf->row, pinf->bank, pinf->col,
+				 pinf->bankgrpnr, pinf->blknr);
 		edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,
 				     p->ue_cnt, 0, 0, 0, 0, 0, -1,
 				     priv->message, "");
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/6] devicetree: Extend synopsys ddrc binding for Xilinx ZynqMP Michal Simek <michal.simek@xilinx.com> - 2017-08-07 09:40 +0200
  [PATCH v2 6/6] edac: synopsys: Enable CE and UE interrupts for ZynqMP DDRC Michal Simek <michal.simek@xilinx.com> - 2017-08-07 09:40 +0200
  [PATCH v2 2/6] edac: synopsys: Add platform specific structures for ddrc controller Michal Simek <michal.simek@xilinx.com> - 2017-08-07 09:50 +0200
    Re: [PATCH v2 2/6] edac: synopsys: Add platform specific structures  for ddrc controller Borislav Petkov <bp@alien8.de> - 2017-08-11 11:10 +0200
      Re: [PATCH v2 2/6] edac: synopsys: Add platform specific structures  for ddrc controller Borislav Petkov <bp@alien8.de> - 2017-08-11 11:30 +0200
  [PATCH v2 4/6] edac: synopsys: Add ECC error injection support Michal Simek <michal.simek@xilinx.com> - 2017-08-07 09:50 +0200
  [PATCH v2 5/6] edac: synopsys: Update ECC error message info Michal Simek <michal.simek@xilinx.com> - 2017-08-07 09:50 +0200
  Re: [PATCH v2 1/6] devicetree: Extend synopsys ddrc binding for  Xilinx ZynqMP Rob Herring <robh@kernel.org> - 2017-08-10 22:50 +0200

csiph-web