Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703123
| From | Noralf Trønnes <noralf@tronnes.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. |
| Date | 2017-08-03 15:40 +0200 |
| Message-ID | <uaow3-Bh-27@gated-at.bofh.it> (permalink) |
| References | <ua8AV-6r3-7@gated-at.bofh.it> <ua8AV-6r3-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Den 02.08.2017 22.32, skrev Eric Anholt:
> drm_bridge_remove() is for unregistering a bridge driver, not for
> detaching a bridge from its consumer.
>
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
Acked-by: Noralf Trønnes <noralf@tronnes.org>
> drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>
> pm_runtime_disable(dev);
>
> - drm_bridge_remove(dsi->bridge);
> vc4_dsi_encoder_destroy(dsi->encoder);
>
> mipi_dsi_host_unregister(&dsi->dsi_host);
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Eric Anholt <eric@anholt.net> - 2017-08-02 22:40 +0200 Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Noralf Trønnes <noralf@tronnes.org> - 2017-08-03 15:40 +0200 Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-04 12:10 +0200
csiph-web