Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.
Date	2017-08-04 12:10 +0200
Message-ID	<uaHIl-5DP-11@gated-at.bofh.it> (permalink)
References	<ua8AV-6r3-7@gated-at.bofh.it> <ua8AV-6r3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed,  2 Aug 2017 13:32:42 -0700
Eric Anholt <eric@anholt.net> wrote:

> drm_bridge_remove() is for unregistering a bridge driver, not for

s/driver/device/

> detaching a bridge from its consumer.
> 
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>  
>  	pm_runtime_disable(dev);
>  
> -	drm_bridge_remove(dsi->bridge);
>  	vc4_dsi_encoder_destroy(dsi->encoder);
>  
>  	mipi_dsi_host_unregister(&dsi->dsi_host);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Eric Anholt <eric@anholt.net> - 2017-08-02 22:40 +0200
  Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Noralf Trønnes <noralf@tronnes.org> - 2017-08-03 15:40 +0200
  Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-04 12:10 +0200

csiph-web