[PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing
Date	2017-08-02 23:20 +0200
Message-ID	<ua9dE-6W9-33@gated-at.bofh.it> (permalink)
References	<ua9dD-6W9-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Dan Carpenter <dan.carpenter@oracle.com>

The UINT_MAX comparison is not needed because "max" is already an unsigned
int, and we expect developer C code max value input to have a sensible
0 - UINT_MAX range. Note that if it so happens to be UINT_MAX + 1 it
would lead to an issue, but we expect the developer to know this.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index ff9148969b92..67fc7b9f41e3 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -924,7 +924,7 @@ static int test_dev_config_update_uint_range(struct kmod_test_device *test_dev,
 	if (ret)
 		return ret;
 
-	if (new < min || new >  max || new > UINT_MAX)
+	if (new < min || new > max)
 		return -EINVAL;
 
 	mutex_lock(&test_dev->config_mutex);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] test_kmod: pending patches for v4.14-rc1 "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200
  [PATCH 2/2] test_kmod: flip INT checks to be consistent "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200
  [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200

csiph-web