Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702501
| From | "Luis R. Rodriguez" <mcgrof@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] test_kmod: flip INT checks to be consistent |
| Date | 2017-08-02 23:20 +0200 |
| Message-ID | <ua9dE-6W9-27@gated-at.bofh.it> (permalink) |
| References | <ua9dD-6W9-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Dan Carpenter <dan.carpenter@oracle.com> Most checks will check for min and then max, except the int check. Flip the checks to be consistent with the other code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> [mcgrof: massaged commit log] Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_kmod.c b/lib/test_kmod.c index 67fc7b9f41e3..fba78d25e825 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev, if (ret) return ret; - if (new > INT_MAX || new < INT_MIN) + if (new < INT_MIN || new > INT_MAX) return -EINVAL; mutex_lock(&test_dev->config_mutex); -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] test_kmod: pending patches for v4.14-rc1 "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200 [PATCH 2/2] test_kmod: flip INT checks to be consistent "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200 [PATCH 1/2] test_kmod: remove paranoid UINT_MAX check on uint range processing "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-08-02 23:20 +0200
csiph-web