Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1702490

Re: [PATCH] mm: ratelimit PFNs busy info message

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: ratelimit PFNs busy info message
Date 2017-08-02 23:20 +0200
Message-ID <ua9dD-6W9-5@gated-at.bofh.it> (permalink)
References <ua5Wp-4AY-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed,  2 Aug 2017 13:44:57 -0400 Jonathan Toppins <jtoppins@redhat.com> wrote:

> The RDMA subsystem can generate several thousand of these messages per
> second eventually leading to a kernel crash. Ratelimit these messages
> to prevent this crash.

Well...  why are all these EBUSY's occurring?  It sounds inefficient (at
least) but if it is expected, normal and unavoidable then perhaps we
should just remove that message altogether?

> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7666,7 +7666,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
>  
>  	/* Make sure the range is really isolated. */
>  	if (test_pages_isolated(outer_start, end, false)) {
> -		pr_info("%s: [%lx, %lx) PFNs busy\n",
> +		pr_info_ratelimited("%s: [%lx, %lx) PFNs busy\n",
>  			__func__, outer_start, end);
>  		ret = -EBUSY;
>  		goto done;

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm: ratelimit PFNs busy info message Jonathan Toppins <jtoppins@redhat.com> - 2017-08-02 19:50 +0200
  Re: [PATCH] mm: ratelimit PFNs busy info message Doug Ledford <dledford@redhat.com> - 2017-08-02 20:10 +0200
  Re: [PATCH] mm: ratelimit PFNs busy info message Andrew Morton <akpm@linux-foundation.org> - 2017-08-02 23:20 +0200
    Re: [PATCH] mm: ratelimit PFNs busy info message Doug Ledford <dledford@redhat.com> - 2017-08-04 21:00 +0200
      Re: [PATCH] mm: ratelimit PFNs busy info message Michal Hocko <mhocko@kernel.org> - 2017-08-07 09:00 +0200
    Re: [PATCH] mm: ratelimit PFNs busy info message Michael Ellerman <mpe@ellerman.id.au> - 2017-08-08 07:40 +0200

csiph-web