Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702356

Re: [PATCH] mm: ratelimit PFNs busy info message

Show all headers | View raw

On Wed, 2017-08-02 at 13:44 -0400, Jonathan Toppins wrote:
> The RDMA subsystem can generate several thousand of these messages
> per
> second eventually leading to a kernel crash. Ratelimit these messages
> to prevent this crash.
> 
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> Reviewed-by: Doug Ledford <dledford@redhat.com>
> Tested-by: Doug Ledford <dledford@redhat.com>
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6d30e914afb6..07b7d3060b21 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7666,7 +7666,7 @@ int alloc_contig_range(unsigned long start,
> unsigned long end,
>  
>  	/* Make sure the range is really isolated. */
>  	if (test_pages_isolated(outer_start, end, false)) {
> -		pr_info("%s: [%lx, %lx) PFNs busy\n",
> +		pr_info_ratelimited("%s: [%lx, %lx) PFNs busy\n",
>  			__func__, outer_start, end);
>  		ret = -EBUSY;
>  		goto done;


FWIW, I've been carrying a version of this for several kernel versions.
 I don't remember when they started, but we have one (and only one)
class of machines: Dell PE R730xd, that generate these errors.  When it
happens, without a rate limit, we get rcu timeouts and kernel oopses. 
With the rate limit, we just get a lot of annoying kernel messages but
the machine continues on, recovers, and eventually the memory
operations all succeed.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: ratelimit PFNs busy info message Jonathan Toppins <jtoppins@redhat.com> - 2017-08-02 19:50 +0200
  Re: [PATCH] mm: ratelimit PFNs busy info message Doug Ledford <dledford@redhat.com> - 2017-08-02 20:10 +0200
  Re: [PATCH] mm: ratelimit PFNs busy info message Andrew Morton <akpm@linux-foundation.org> - 2017-08-02 23:20 +0200
    Re: [PATCH] mm: ratelimit PFNs busy info message Doug Ledford <dledford@redhat.com> - 2017-08-04 21:00 +0200
      Re: [PATCH] mm: ratelimit PFNs busy info message Michal Hocko <mhocko@kernel.org> - 2017-08-07 09:00 +0200
    Re: [PATCH] mm: ratelimit PFNs busy info message Michael Ellerman <mpe@ellerman.id.au> - 2017-08-08 07:40 +0200

csiph-web