Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702113

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

Show all headers | View raw

> +static struct phy_driver rockchip_phy_driver[] = {
> +{
> +	.phy_id			= 0x1234d400,
> +	.phy_id_mask		= 0xfffffff0,
> +	.name			= "Rockchip internal EPHY",
> +	.features		= (PHY_BASIC_FEATURES | SUPPORTED_Pause
> +				   | SUPPORTED_Asym_Pause),

Please take a look at Documentation/networking/phy.txt and
Fixes: 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause")

Pause frames / flow control

 The PHY does not participate directly in flow control/pause frames except by
 making sure that the SUPPORTED_Pause and SUPPORTED_AsymPause bits are set in
 MII_ADVERTISE to indicate towards the link partner that the Ethernet MAC
 controller supports such a thing. Since flow control/pause frames generation
 involves the Ethernet MAC driver, it is recommended that this driver takes care
 of properly indicating advertisement and support for such features by setting
 the SUPPORTED_Pause and SUPPORTED_AsymPause bits accordingly. This can be done
 either before or after phy_connect() and/or as a result of implementing the
 ethtool::set_pauseparam feature.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/11] Add the internal phy support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 02/11] multi_v7_defconfig: Make rockchip phy built-in David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_PHY David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 01/11] net: phy: Add rockchip phy driver support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
    Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-02 08:30 +0200
    Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-08-02 15:30 +0200
      Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support "David.Wu" <david.wu@rock-chips.com> - 2017-08-09 09:10 +0200
  [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
    Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Florian Fainelli <f.fainelli@gmail.com> - 2017-08-02 19:40 +0200
      Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Chen-Yu Tsai <wens@csie.org> - 2017-08-03 13:10 +0200
        Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-09 10:50 +0200
          Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-09 11:40 +0200
            Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Chen-Yu Tsai <wens@csie.org> - 2017-08-10 04:50 +0200
              Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-10 09:50 +0200
          Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Florian Fainelli <f.fainelli@gmail.com> - 2017-08-10 00:50 +0200
      Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-03 16:10 +0200
  [PATCH v3 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 09/11] ARM: dts: rk3228-evb: Enable the internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:30 +0200
    Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support  for rk3328 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-08-02 13:50 +0200
    Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support  for rk3328 Florian Fainelli <f.fainelli@gmail.com> - 2017-08-02 19:50 +0200
  [PATCH v3 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu <david.wu@rock-chips.com> - 2017-08-02 08:30 +0200

csiph-web