Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701762

Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support

Show all headers | View raw

Hello I have some minor comment below

> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/mii.h>
> +#include <linux/ethtool.h>
> +#include <linux/phy.h>
> +#include <linux/netdevice.h>

in alphabetic order please

[...]
> +static int rockchip_init_tstmode(struct phy_device *phydev)
> +{
> +	int ret;
> +
> +	/* Enable access to Analog and DSP register banks */
> +	ret = phy_write(phydev, SMI_ADDR_TSTCNTL, 0x0400);
> +	if (ret)
> +		return ret;
> +
> +	ret = phy_write(phydev, SMI_ADDR_TSTCNTL, 0x0000);
> +	if (ret)
> +		return ret;
> +
> +	return phy_write(phydev, SMI_ADDR_TSTCNTL, 0x0400);
> +}
> +
> +static int rockchip_close_tstmode(struct phy_device *phydev)
> +{
> +	/* Back to basic register bank */
> +	return phy_write(phydev, SMI_ADDR_TSTCNTL, 0x0000);

The reuse of 0x0000 and 0x0400 seems to promote a define use

[...]
> +static struct phy_driver rockchip_phy_driver[] = {
> +{
> +	.phy_id			= 0x1234d400,
> +	.phy_id_mask		= 0xfffffff0,
> +	.name			= "Rockchip internal EPHY",
> +	.features		= (PHY_BASIC_FEATURES | SUPPORTED_Pause
> +				   | SUPPORTED_Asym_Pause),
> +	.flags			= PHY_IS_INTERNAL,
> +	.link_change_notify	= rockchip_link_change_notify,
> +	.soft_reset		= genphy_soft_reset,
> +	.config_init		= rockchip_internal_phy_config_init,
> +	.config_aneg		= rockchip_config_aneg,
> +	.read_status		= genphy_read_status,
> +	.suspend		= genphy_suspend,
> +	.resume			= rockchip_phy_resume,
> +},
> +};
> +
> +module_phy_driver(rockchip_phy_driver);
> +
> +static struct mdio_device_id __maybe_unused rockchip_phy_tbl[] = {
> +	{ 0x1234d400, 0xfffffff0 },

Same comment for phy_id, use a define

Regards
Corentin Labbe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/11] Add the internal phy support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 02/11] multi_v7_defconfig: Make rockchip phy built-in David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_PHY David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 01/11] net: phy: Add rockchip phy driver support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
    Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-02 08:30 +0200
    Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-08-02 15:30 +0200
      Re: [PATCH v3 01/11] net: phy: Add rockchip phy driver support "David.Wu" <david.wu@rock-chips.com> - 2017-08-09 09:10 +0200
  [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
    Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Florian Fainelli <f.fainelli@gmail.com> - 2017-08-02 19:40 +0200
      Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Chen-Yu Tsai <wens@csie.org> - 2017-08-03 13:10 +0200
        Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-09 10:50 +0200
          Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-09 11:40 +0200
            Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Chen-Yu Tsai <wens@csie.org> - 2017-08-10 04:50 +0200
              Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-10 09:50 +0200
          Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support Florian Fainelli <f.fainelli@gmail.com> - 2017-08-10 00:50 +0200
      Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-08-03 16:10 +0200
  [PATCH v3 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 09/11] ARM: dts: rk3228-evb: Enable the internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:20 +0200
  [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-08-02 08:30 +0200
    Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support  for rk3328 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-08-02 13:50 +0200
    Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support  for rk3328 Florian Fainelli <f.fainelli@gmail.com> - 2017-08-02 19:50 +0200
  [PATCH v3 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu <david.wu@rock-chips.com> - 2017-08-02 08:30 +0200

csiph-web