Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1700497

Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108

From Heiko Stuebner <heiko@sntech.de>
Newsgroups linux.kernel
Subject Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108
Date 2017-08-01 01:20 +0200
Message-ID <u9s8F-428-1@gated-at.bofh.it> (permalink)
References <u9fOa-4XH-17@gated-at.bofh.it> <u9fXR-513-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Andy,

Am Montag, 31. Juli 2017, 18:19:19 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> 
>  arch/arm/boot/dts/rv1108.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index 1fc467e..958fecd 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -275,6 +275,18 @@
>  		status = "disabled";
>  	};
>  
> +	adc: adc@1038c000 {
> +		compatible = "rockchip,rk3399-saradc";

you should amend the binding txt to make this something like
compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc"

See for example the bindings/mmc/rockchip-dw-mshc.txt as inspiration.

Heiko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/14] Support more devices on rockchip rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:10 +0200
  [PATCH 05/14] i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 05/14] i2c: rk3x: add support for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
  [PATCH 09/14] ARM: dts: rockchip: add pwm dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 09/14] ARM: dts: rockchip: add pwm dt node for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
  [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 17:20 +0200
      Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 21:00 +0200
        Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 02:40 +0200
  [PATCH 07/14] spi: rockchip: add compatible string for rv1108 spi Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 06/14] ARM: dts: rockchip: add i2c dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 01:20 +0200
  [PATCH 08/14] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
    Re: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 10:50 +0200
  [PATCH 04/14] dt-bindings: i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 14/14] ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200
  [PATCH 13/14] ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200
  [PATCH 12/14] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200

csiph-web