Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699899

[PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108

Show all headers | View raw

Some pins like i2c SCL/SDA need the schmitt input function
to avoid crosstalk problems.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 drivers/pinctrl/pinctrl-rockchip.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index e831647..868cb9c 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1084,6 +1084,36 @@ static void rv1108_calc_drv_reg_and_bit(struct rockchip_pin_bank *bank,
 	*bit *= RV1108_DRV_BITS_PER_PIN;
 }
 
+#define RV1108_SCHMITT_PMU_OFFSET		0x30
+#define RV1108_SCHMITT_GRF_OFFSET		0x388
+#define RV1108_SCHMITT_BANK_STRIDE		8
+#define RV1108_SCHMITT_PINS_PER_GRF_REG		16
+#define RV1108_SCHMITT_PINS_PER_PMU_REG		8
+
+static int rv1108_calc_schmitt_reg_and_bit(struct rockchip_pin_bank *bank,
+					   int pin_num,
+					   struct regmap **regmap,
+					   int *reg, u8 *bit)
+{
+	struct rockchip_pinctrl *info = bank->drvdata;
+	int pins_per_reg;
+
+	if (bank->bank_num == 0) {
+		*regmap = info->regmap_pmu;
+		*reg = RV1108_SCHMITT_PMU_OFFSET;
+		pins_per_reg = RV1108_SCHMITT_PINS_PER_PMU_REG;
+	} else {
+		*regmap = info->regmap_base;
+		*reg = RV1108_SCHMITT_GRF_OFFSET;
+		pins_per_reg = RV1108_SCHMITT_PINS_PER_GRF_REG;
+		*reg += (bank->bank_num  - 1) * RV1108_SCHMITT_BANK_STRIDE;
+	}
+	*reg += ((pin_num / pins_per_reg) * 4);
+	*bit = pin_num % pins_per_reg;
+
+	return 0;
+}
+
 #define RK2928_PULL_OFFSET		0x118
 #define RK2928_PULL_PINS_PER_REG	16
 #define RK2928_PULL_BANK_STRIDE		8
@@ -3017,6 +3047,7 @@ static struct rockchip_pin_ctrl rv1108_pin_ctrl = {
 	.pmu_mux_offset		= 0x0,
 	.pull_calc_reg		= rv1108_calc_pull_reg_and_bit,
 	.drv_calc_reg		= rv1108_calc_drv_reg_and_bit,
+	.schmitt_calc_reg	= rv1108_calc_schmitt_reg_and_bit,
 };
 
 static struct rockchip_pin_bank rk2928_pin_banks[] = {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] Support more devices on rockchip rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:10 +0200
  [PATCH 05/14] i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 05/14] i2c: rk3x: add support for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
  [PATCH 09/14] ARM: dts: rockchip: add pwm dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 09/14] ARM: dts: rockchip: add pwm dt node for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
  [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 17:20 +0200
      Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 21:00 +0200
        Re: [PATCH 10/14] ARM: dts: rockchip: add watchdog dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-08-02 02:40 +0200
  [PATCH 07/14] spi: rockchip: add compatible string for rv1108 spi Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 06/14] ARM: dts: rockchip: add i2c dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Heiko Stuebner <heiko@sntech.de> - 2017-08-01 01:20 +0200
  [PATCH 08/14] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
    Re: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Heiko Stübner <heiko@sntech.de> - 2017-07-31 13:30 +0200
    Re: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108 Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 10:50 +0200
  [PATCH 04/14] dt-bindings: i2c: rk3x: add support for rv1108 Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:20 +0200
  [PATCH 14/14] ARM: dts: rockchip: add accelerometer bma250e dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200
  [PATCH 13/14] ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200
  [PATCH 12/14] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan <andy.yan@rock-chips.com> - 2017-07-31 12:30 +0200

csiph-web