Re: [v3] mm: Add SLUB free list pointer obfuscation

From	Alexander Popov <alex.popov@linux.com>
Newsgroups	linux.kernel
Subject	Re: [v3] mm: Add SLUB free list pointer obfuscation
Date	2017-07-31 22:20 +0200
Message-ID	<u9pku-2jJ-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <u7vNn-1yO-5@gated-at.bofh.it> <u7xma-2CU-21@gated-at.bofh.it> <u7xPb-2P1-19@gated-at.bofh.it> <u7ZLr-3JP-7@gated-at.bofh.it> <u80Rc-4lY-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Christopher and Kees,

Excuse me for the delayed reply.

On 28.07.2017 02:53, Christopher Lameter wrote:
> On Fri, 28 Jul 2017, Alexander Popov wrote:
> 
>> I don't really like ignoring double-free. I think, that:
>>   - it will hide dangerous bugs in the kernel,
>>   - it can make some kernel exploits more stable.
>> I would rather add BUG_ON to set_freepointer() behind SLAB_FREELIST_HARDENED. Is
>> it fine?
> 
> I think Kees already added some logging output.

Hm, I don't see anything like that in v4 of "SLUB free list pointer
obfuscation": https://patchwork.kernel.org/patch/9864165/

>> At the same time avoiding the consequences of some double-free errors is better
>> than not doing that. It may be considered as kernel "self-healing", I don't
>> know. I can prepare a second patch for do_slab_free(), as you described. Would
>> you like it?
> 
> The SLUB allocator is already self healing if you enable the option to do
> so on bootup (covers more than just the double free case). What you
> propose here is no different than that and just another way of having
> similar functionality. In the best case it would work the same way.

Ok, I see. Thanks.

Best regards,
Alexander

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-24 23:20 +0200
  Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-25 11:50 +0200
  Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 02:30 +0200
    Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-26 16:50 +0200
      Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 18:30 +0200
        Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-26 19:00 +0200
          Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 19:20 +0200
            Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-27 17:20 +0200
          Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-28 00:50 +0200
            Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-28 02:00 +0200
              Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-31 22:20 +0200

csiph-web