Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1697362

Re: [v3] mm: Add SLUB free list pointer obfuscation

From Christopher Lameter <cl@linux.com>
Newsgroups linux.kernel
Subject Re: [v3] mm: Add SLUB free list pointer obfuscation
Date 2017-07-26 19:00 +0200
Message-ID <u7xPb-2P1-19@gated-at.bofh.it> (permalink)
References <u02Qa-5ct-1@gated-at.bofh.it> <u6SVI-227-15@gated-at.bofh.it> <u7in7-1wt-3@gated-at.bofh.it> <u7vNn-1yO-5@gated-at.bofh.it> <u7xma-2CU-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 26 Jul 2017, Kees Cook wrote:

> >> What happens if, instead of BUG_ON, we do:
> >>
> >> if (unlikely(WARN_RATELIMIT(object == fp, "double-free detected"))
> >>         return;
> >
> > This may work for the free fastpath but the set_freepointer function is
> > use in multiple other locations. Maybe just add this to the fastpath
> > instead of to this fucnction?
>
> Do you mean do_slab_free()?

Yes inserting these lines into do_slab_free() would simple ignore the
double free operation in the fast path and that would be safe.

Although in either case we are adding code to the fastpath...

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-24 23:20 +0200
  Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-25 11:50 +0200
  Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 02:30 +0200
    Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-26 16:50 +0200
      Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 18:30 +0200
        Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-26 19:00 +0200
          Re: [v3] mm: Add SLUB free list pointer obfuscation Kees Cook <keescook@chromium.org> - 2017-07-26 19:20 +0200
            Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-27 17:20 +0200
          Re: [v3] mm: Add SLUB free list pointer obfuscation Alexander Popov <alex.popov@linux.com> - 2017-07-28 00:50 +0200
            Re: [v3] mm: Add SLUB free list pointer obfuscation Christopher Lameter <cl@linux.com> - 2017-07-28 02:00 +0200

csiph-web