Re: [PATCH v5] vfat: Deduplicate hex2bin()

From	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] vfat: Deduplicate hex2bin()
Date	2017-07-31 23:00 +0200
Message-ID	<u9pXc-2wz-13@gated-at.bofh.it> (permalink)
References	<u9k1s-7qO-3@gated-at.bofh.it> <u9nVn-1jR-15@gated-at.bofh.it> <u9oHM-1Rm-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

>> > +				fill = hex2bin(hc, ip + 1, 2);
>> > +				if (fill)
>> > +					return fill;
>> 
>> This should not use random errno (in this case, it is -1 (EPERM)).
>
> You perhaps missed the side note I put after --- line.
> It reflects this change.

Sure, I missed to read it. But same here, hex2bin() doesn't care FS's
errno, it is what "random errno" I meant (I.e. hex2bin() might change it
to bool or any other errno again).
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 16:40 +0200
  [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 20:50 +0200
    Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-31 21:40 +0200
      Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 23:00 +0200
        Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-01 15:00 +0200
  Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 20:50 +0200
    Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 21:40 +0200
      Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 23:00 +0200

csiph-web