Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1700385

Re: [PATCH v5] vfat: Deduplicate hex2bin()

From OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Newsgroups linux.kernel
Subject Re: [PATCH v5] vfat: Deduplicate hex2bin()
Date 2017-07-31 23:00 +0200
Message-ID <u9pXb-2wz-1@gated-at.bofh.it> (permalink)
References <u9k1s-7qO-3@gated-at.bofh.it> <u9nVn-1jR-15@gated-at.bofh.it> <u9nVn-1jR-13@gated-at.bofh.it> <u9oHM-1Rm-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

>> +
>> +                               *(wchar_t *)op = uc[0] << 8 | uc[1];
>> +
>> +                               op += 2;
>
> This had been in the original patch 6 years ago and had been refused
> because of endianess issues.

Sorry, I forgot what I said completely. Maybe I changed my mind? 

			if (uni_xlate == 1) {
				*op++ = ':';
				op = hex_byte_pack(op, ec >> 8);
				op = hex_byte_pack(op, ec);
				len -= 5;

Here is output. So "uc[0] << 8 | uc[1]" is right code, isn't it?

>>                                 charlen = nls->char2uni(ip, len - i,
>> -                                                                       (wchar_t *)op);
>> +                                                       (wchar_t *)op);
>
> It perfectly fits one line.

It over 80 column.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 16:40 +0200
  [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 20:50 +0200
    Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-31 21:40 +0200
      Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 23:00 +0200
        Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-01 15:00 +0200
  Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 20:50 +0200
    Re: [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 21:40 +0200
      Re: [PATCH v5] vfat: Deduplicate hex2bin() OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2017-07-31 23:00 +0200

csiph-web