Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1700096

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Show all headers | View raw

Hi Egil,

Egil Hjelmeland <privat@egil-hjelmeland.no> writes:

>>> +	for (p = 0; p <= 2; p++) {
>> 
>> Exclusive limits are often prefer, i.e. 'p < 3'.
>> 
> OK, that can be nice when I later introduce LAN9303_NUM_PORTS = 3.

This is indeed another reason what exclusive limits are prefered ;-)

>>> +		int ret;
>>> +
>>> +		ret = lan9303_disable_packet_processing(chip, p);
>>> +		if (ret)
>>> +			return ret;
>> 
>> When any non-zero return code means an error, we usually see 'err'
>> instead of 'ret'.
>> 
>
> But 'ret' is used throughout the rest of the file. Is it not better to
> be locally consistent?

You are correct, I was missing a bit of context here.

>>>   	case 1:
>>> -		return lan9303_enable_packet_processing(chip, port);
>> 
>> Is this deletion intentional? The commit message does not explain this.
>> 
>> When possible, it is appreciated to separate functional from
>> non-functional changes. For example one commit adding the loop in
>> lan9303_disable_processing and another one to not enable/disable packet
>> processing on port 1.
>> 
>
> Case fall through, the change is purely non-functional.
>
> You are perhaps thinking of the patch in my first series where I removed
> disable of port 0. I have put that on hold. Juergen says that the
> mainline driver works out of the box for him. So I will investigate
> that problem bit more.

Correct! I misread, my bad. This is indeed cleaner with this patch. With
the LAN9303_NUM_PORTS limit and detailed commit message, the patch LGTM.


Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 13:40 +0200
  [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 13:40 +0200
    Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Andrew Lunn <andrew@lunn.ch> - 2017-07-31 15:50 +0200
      Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 16:20 +0200
        Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Andrew Lunn <andrew@lunn.ch> - 2017-07-31 16:50 +0200
    Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 16:10 +0200
      Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 16:40 +0200
        Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 16:50 +0200
          Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 17:00 +0200
            Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify  lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 17:10 +0200
              Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 17:20 +0200
            Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 17:10 +0200
  Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Andrew Lunn <andrew@lunn.ch> - 2017-07-31 15:30 +0200
    Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 15:40 +0200

csiph-web