Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1700040
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing |
| Date | 2017-07-31 15:30 +0200 |
| Message-ID | <u9iVH-6No-9@gated-at.bofh.it> (permalink) |
| References | <u9hdg-5GQ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 31, 2017 at 01:33:53PM +0200, Egil Hjelmeland wrote: > First patch: > Change lan9303_enable_packet_processing, > lan9303_disable_packet_processing(): > Pass port number (0,1,2) as parameter instead of port offset. > Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG() Hi Egil The cover note and the commit message should concentrate on the Why, not the What. I can see the What by reading the patch. Why do you want to pass port numbers? Note that for netdev, the cover note also ends up in git as part of the history. Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 13:40 +0200
[PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 13:40 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Andrew Lunn <andrew@lunn.ch> - 2017-07-31 15:50 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 16:20 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Andrew Lunn <andrew@lunn.ch> - 2017-07-31 16:50 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 16:10 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 16:40 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 16:50 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 17:00 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 17:10 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 17:20 +0200
Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-31 17:10 +0200
Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Andrew Lunn <andrew@lunn.ch> - 2017-07-31 15:30 +0200
Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-31 15:40 +0200
csiph-web