Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
Date	2017-07-31 15:50 +0200
Message-ID	<u9jf3-6U3-3@gated-at.bofh.it> (permalink)
References	<tZnah-2HZ-5@gated-at.bofh.it> <tZsWm-6Q1-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
>> Some of include directives in include/linux/gpio/driver.h are
>> unneeded because the header does not need to know the content of
>> struct device, irq_chip, etc.  Just declare they are structures.
>>
>> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>> turned out to be necessary for irq_flow_handler_t and spinlock_t,
>> respectively.
>>
>> Each driver should include what it needs without relying on what is
>> implicitly included from <linux/gpio/driver.h>.  This will cut down
>> unnecessary header parsing.
>
> If Linus is okay with the following proposal I would rather go with it,
> i.e. logical split the series to
>
> 1. Fix IRQ related headers inclusion
> 2. Fix pinconf-generic.h inclusion
> 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

That works fine with me, but also one big patch actually, I do not
want to make it too much work to refactor obviously incorrect things.

As soon as we have rough consensus on this and the build robot
are happy I will apply it to GPIO and also pull it into the pinctrl
subsystem.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Linus Walleij <linus.walleij@linaro.org> - 2017-07-31 15:50 +0200
  Re: [PATCH] gpio: drop unnecessary includes from  include/linux/gpio/driver.h Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 16:10 +0200
    Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Linus Walleij <linus.walleij@linaro.org> - 2017-08-01 10:00 +0200
      Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-01 13:10 +0200
        Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-02 03:30 +0200

csiph-web