Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
Date	2017-08-02 03:30 +0200
Message-ID	<u9QE1-3cM-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <tZsWm-6Q1-7@gated-at.bofh.it> <u9jf3-6U3-3@gated-at.bofh.it> <u9jyq-7fE-11@gated-at.bofh.it> <u9AfV-pF-25@gated-at.bofh.it> <u9DdL-3gc-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi.

2017-08-01 20:04 GMT+09:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote:
>>>> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko
>>>> <andriy.shevchenko@linux.intel.com> wrote:
>
>>>> > If Linus is okay with the following proposal I would rather go with
>>>> > it,
>>>> > i.e. logical split the series to
>>>> >
>>>> > 1. Fix IRQ related headers inclusion
>>>> > 2. Fix pinconf-generic.h inclusion
>>>> > 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)
>>>>
>>>> That works fine with me, but also one big patch actually, I do not
>>>> want to make it too much work to refactor obviously incorrect things.
>>>>
>>>> As soon as we have rough consensus on this and the build robot
>>>> are happy I will apply it to GPIO and also pull it into the pinctrl
>>>> subsystem.
>>>
>>> For me priorities like this:
>>> 1) it works after the patch being applied (no regressions);
>>> 2) it makes code cleaner at the end;
>>> 3) it is presented in logically split parts.
>>>
>>> So, as long as 1) and 2) are satisfied I can neglect on 3).
>>
>> We are in violent agreement :D
>
> What I would like to say is that is up to you after all :-)
> For me looks better to split.



I will split this into sensible chunks.


As I mentioned before, linux/gpio/driver.h is included from several sub-systems,
so I need at least two development cycles to finish this task.


Maybe,

[1] Send patches to subsystems (gpio, pinctrl, etc.) for v4.14
     (splitting into sensible chunks, like per-driver)
[2] Drop unneeded includes from linux/gpio/driver.h for v4.15




-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Linus Walleij <linus.walleij@linaro.org> - 2017-07-31 15:50 +0200
  Re: [PATCH] gpio: drop unnecessary includes from  include/linux/gpio/driver.h Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-31 16:10 +0200
    Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Linus Walleij <linus.walleij@linaro.org> - 2017-08-01 10:00 +0200
      Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-01 13:10 +0200
        Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-02 03:30 +0200

csiph-web