Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699907

Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible"

Show all headers | View raw

SZ Lin <sz.lin@moxa.com> writes:

> ERROR: code indent should use tabs where possible
> +^I^I         "Need to wait for TPM to finish\n");$
>
> Signed-off-by: SZ Lin <sz.lin@moxa.com>
> ---
>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083eced2..23913fc86158 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -127,7 +127,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
>  
>  	if (ibmvtpm->tpm_processing_cmd) {
>  		dev_info(ibmvtpm->dev,
> -		         "Need to wait for TPM to finish\n");
> +			"Need to wait for TPM to finish\n");

There's no reason for that to be on a separate line at all. Just make it
a single line dev_info( ... );

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] tpm: tpm_ibmvtpm: - style fix SZ Lin <sz.lin@moxa.com> - 2017-07-29 09:30 +0200
  [PATCH 3/5] Fix 'void function return statements are not generally useful' warning SZ Lin <sz.lin@moxa.com> - 2017-07-29 09:30 +0200
  [PATCH 4/5] Remove unneccessary 'out of memory' message SZ Lin <sz.lin@moxa.com> - 2017-07-29 09:30 +0200
  [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" SZ Lin <sz.lin@moxa.com> - 2017-07-29 09:30 +0200
    Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" Michael Ellerman <mpe@ellerman.id.au> - 2017-07-31 12:30 +0200
  Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-02 14:40 +0200

csiph-web