Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702080

Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix

Show all headers | View raw

On Sat, Jul 29, 2017 at 03:24:28PM +0800, SZ Lin wrote:
> Fix styling WARNINGs and Errors of tpm_ibmvtpm.c driver by using checkpatch.pl

Changes are great but you should revise the patch series so that you
expain in each commit what goes wrong instead of copy paste of the
checkpatch output and why your changes fixes the problem.

> 
> SZ Lin (5):
>   Fix packed and aligned attribute warnings.
>   Fix "ERROR: code indent should use tabs where possible"
>   Fix 'void function return statements are not generally useful' warning
>   Remove unneccessary 'out of memory' message
>   Use __func__ instead of function name
> 
>  drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++--------------
>  drivers/char/tpm/tpm_ibmvtpm.h |  2 +-
>  2 files changed, 10 insertions(+), 15 deletions(-)
> 
> --
> 2.13.3
> 

/Jarkko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-02 14:40 +0200

csiph-web