Re: [PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures

From	Stefan Wahren <stefan.wahren@i2se.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures
Date	2017-07-31 08:00 +0200
Message-ID	<u9bUe-2kb-3@gated-at.bofh.it> (permalink)
References	<u8tq9-6KR-3@gated-at.bofh.it> <u8tq9-6KR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 29.07.2017 um 07:59 schrieb Julia Lawall:
> The mmc_host_ops structure is only stored in the ops field of an
> mmc_host structure, which is declared as const.  Thus the mmc_host_ops
> structure itself can be const.
>
> Done with the help of Coccinelle.
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct mmc_host_ops i@p = { ... };
>
> @ok1@
> struct mmc_host *mmc;
> identifier r.i;
> position p;
> @@
> mmc->ops = &i@p
>
> @bad@
> position p != {r.p,ok1.p};
> identifier r.i;
> struct mmc_host_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct mmc_host_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200
  Re: [PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures Stefan Wahren <stefan.wahren@i2se.com> - 2017-07-31 08:00 +0200

csiph-web