Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701604

Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers
Date Wed, 02 Aug 2017 02:40:01 +0200
Message-ID <u9PRD-2Dc-1@gated-at.bofh.it> (permalink)
References <u97QC-858-1@gated-at.bofh.it> <u9NPP-1sk-3@gated-at.bofh.it>
X-Original-To David Miller <davem@davemloft.net>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=O2THqW/FQeU+bvWF9MAaN07LvnHq1enwQUUbE14qT+Q=; b=AkQl3XC/PcgrpCZoKLH3ZnbnB/5PUIuzmA8GcFmGG6sY2ZIit70bF8X6ck1huaivOc rz5YucCK7icbP3Gp6LhIf4JWNyfpHIgHa9YE32h149nKiQVu9zFEM1dXmz8XxN3vGsUu MoiOXD2BOa8FYARxaW9IipwR4TzYZwx9m4A/QjHtpmACahjqkYEneabZy0JdCFswfuQb foYiellnAqs3WOioUJDnpLnKU/jftLpGNC2PGwKyRl50I6G+6bkB8ByyTk43mLUpOs1i fAP6dP9HIpAEBRLAIM3b7fmbWOvsbl3130PBOQMcyvo24Wg1jej06HJ0ZKhUiuXagw1J A3xQ==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=O2THqW/FQeU+bvWF9MAaN07LvnHq1enwQUUbE14qT+Q=; b=kR9gjwLbMMPeKMxGyfvuxkgllPPSrruHuIlLGYDkhxb3Sa5r8SxIBH6tMJFBpDwp8/ 7fqzHGQ+B2rmgyNCS9pQvQckndTaAq3bsuOhbOe7gKrFWEvWo5/Y4hhnvqqdk1XeQiE5 fJbvTyDLoVehF744oNThFSF2+J1MEHLVGjNCY=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=O2THqW/FQeU+bvWF9MAaN07LvnHq1enwQUUbE14qT+Q=; b=WeClr12CgUKtLazF9aPdbj2KOmmNAJMtkEDB9ghSvSdNEb1igktwdT33A/y57A1xHO C6rzXWV7GoOs5cftTBR6WKbkeCd7EQea8+tMt2FfdcEJX9Xct2M2Gemhiy2ZIeM71d5Z 7qvuiJBQBRc+uswMLDqiKfy/lOTjYcxXdzWym/s2ctLhsW6E4I8dyt/+VH2XomO5cnlD 5nlTAibo02zY/g00wtsbxlbohyKHBFji1Q5xfiI8yxvFoiMo7EN2mcPxjPOidmSKJx4q osZdeNfSdyt3JFZj7ICJbNQOabQ3vncvV355m8DixtGP+vVm5COHy4hHMrlJ1jw+5dwn ls2w==
X-Gm-Message-State AIVw110+oIsWgXyKNapM/AOKB3BJOJlHd+b9TQfMWGnefY46R8RbP51E sSjMTs0hXq9VStl56/+wpx1gNrk4Nowz
X-Received by 10.107.188.197 with SMTP id m188mr1393550iof.239.1501634039627; Tue, 01 Aug 2017 17:33:59 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth I-j8iIIhr9ODfadt0fpCpdxYEyQ
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, Network Development <netdev@vger.kernel.org>
X-Original-Date Tue, 1 Aug 2017 17:33:59 -0700
X-Original-Message-ID <CAGXu5jJOsTfpBOzg1AkVyCch6x06EDDkFU8aCZG7fNPrxJY8QQ@mail.gmail.com>
X-Original-References <20170731013117.GA67801@beast> <20170801.152943.804666349488319640.davem@davemloft.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1701604

Show key headers only | View raw


On Tue, Aug 1, 2017 at 3:29 PM, David Miller <davem@davemloft.net> wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Sun, 30 Jul 2017 18:31:17 -0700
>
>> In preparation for the randstruct gcc plugin performing randomization of
>> structures that are entirely function pointers, use designated initializers
>> so the compiler doesn't get angry.
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> This is a prerequisite for the future randstruct fptr randomization. I'd
>> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
>> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.
>
> Please queue this up into the gcc-plugin tree then:
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> It isn't a bug fix so I would only have put it into 'net-next' rather
> than 'net'.

Okay, sounds good. I'll carry it. Thanks!

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers David Miller <davem@davemloft.net> - 2017-08-02 00:30 +0200
  Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers Kees Cook <keescook@chromium.org> - 2017-08-02 02:40 +0200

csiph-web