Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701545 > unrolled thread

Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

Started byDavid Miller <davem@davemloft.net>
First post2017-08-02 00:30 +0200
Last post2017-08-02 02:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers David Miller <davem@davemloft.net> - 2017-08-02 00:30 +0200
    Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers Kees Cook <keescook@chromium.org> - 2017-08-02 02:40 +0200

#1701545 — Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

FromDavid Miller <davem@davemloft.net>
Date2017-08-02 00:30 +0200
SubjectRe: [PATCH] drivers/net/wan/z85230.c: Use designated initializers
Message-ID<u9NPP-1sk-3@gated-at.bofh.it>
From: Kees Cook <keescook@chromium.org>
Date: Sun, 30 Jul 2017 18:31:17 -0700

> In preparation for the randstruct gcc plugin performing randomization of
> structures that are entirely function pointers, use designated initializers
> so the compiler doesn't get angry.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> This is a prerequisite for the future randstruct fptr randomization. I'd
> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.

Please queue this up into the gcc-plugin tree then:

Acked-by: David S. Miller <davem@davemloft.net>

It isn't a bug fix so I would only have put it into 'net-next' rather
than 'net'.

Thanks.

[toc] | [next] | [standalone]


#1701604

FromKees Cook <keescook@chromium.org>
Date2017-08-02 02:40 +0200
Message-ID<u9PRD-2Dc-1@gated-at.bofh.it>
In reply to#1701545
On Tue, Aug 1, 2017 at 3:29 PM, David Miller <davem@davemloft.net> wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Sun, 30 Jul 2017 18:31:17 -0700
>
>> In preparation for the randstruct gcc plugin performing randomization of
>> structures that are entirely function pointers, use designated initializers
>> so the compiler doesn't get angry.
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> This is a prerequisite for the future randstruct fptr randomization. I'd
>> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
>> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.
>
> Please queue this up into the gcc-plugin tree then:
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> It isn't a bug fix so I would only have put it into 'net-next' rather
> than 'net'.

Okay, sounds good. I'll carry it. Thanks!

-Kees

-- 
Kees Cook
Pixel Security

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web