Re: [PATCH v2 11/13] xen/pvcalls: implement release command

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 11/13] xen/pvcalls: implement release command
Date	2017-08-01 18:10 +0200
Message-ID	<u9HU6-68E-23@gated-at.bofh.it> (permalink)
References	(2 earlier) <u7fyY-8aW-75@gated-at.bofh.it> <u7VRv-195-7@gated-at.bofh.it> <u9rvY-3zm-15@gated-at.bofh.it> <u9Hho-5Gd-33@gated-at.bofh.it> <u9Hr4-5Jr-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> BTW, I also noticed that in rcvmsg you are calling
>> wait_event_interruptible() while holding the lock. Have you tested with
>> CONFIG_DEBUG_ATOMIC_SLEEP? (or maybe it's some other config  option that
>> would complain about those sorts of thing)
> I believe sleeping while holding a mutex is allowed. Sleeping in
> spinlocked paths is bad.

Oh, right. I was thinking about spinlocks. Sorry.

-boris

>
> BTW: You are looking for CONFIG_DEBUG_MUTEXES (see
> Documentation/locking/mutex-design.txt ).
>
>
> Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 11/13] xen/pvcalls: implement release command Stefano Stabellini <sstabellini@kernel.org> - 2017-08-01 00:40 +0200
  Re: [PATCH v2 11/13] xen/pvcalls: implement release command Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-01 17:30 +0200
    Re: [PATCH v2 11/13] xen/pvcalls: implement release command Juergen Gross <jgross@suse.com> - 2017-08-01 17:40 +0200
      Re: [PATCH v2 11/13] xen/pvcalls: implement release command Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-01 18:10 +0200

csiph-web