Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698802

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

Show all headers | View raw

On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> Hello
> 
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
> 
> This patchs series adds a new way to find if the PHY is internal, via its
> compatible.

http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144

Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
warning. But still, your device tree gives the wrong idea.

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

    Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
  [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
    Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY  via compatible Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 12:00 +0200
    Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY  via compatible Chen-Yu Tsai <wens@csie.org> - 2017-07-28 12:00 +0200
  [PATCH 1/3] dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
  Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Chen-Yu Tsai <wens@csie.org> - 2017-07-28 12:00 +0200
    Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 15:50 +0200
  Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 16:00 +0200
    Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 16:30 +0200
      Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 16:40 +0200
        Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 16:50 +0200
          Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:00 +0200
          Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 20:00 +0200
            Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-29 08:50 +0200
              Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-31 14:30 +0200
              Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Chen-Yu Tsai <wens@csie.org> - 2017-07-31 14:30 +0200

csiph-web