Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698647

Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible

Show all headers | View raw

On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
>
> This patch adds a new way to find if the PHY is internal, via its
> compatible.
>
> Since the phy_mode of the internal PHY does need to be know, the
> variant internal_phy member is converted to a boolean.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index fffd6d5fc907..04f7ddd802b0 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -48,7 +48,7 @@
>   */
>  struct emac_variant {
>         u32 default_syscon_value;
> -       int internal_phy;
> +       bool internal_phy;

Nit: please add a verb to the name, like "has_internal_phy",
or even "soc_has_internal_phy". This makes it clear what this
property represents.

ChenYu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
  [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
    Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY  via compatible Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 12:00 +0200
    Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY  via compatible Chen-Yu Tsai <wens@csie.org> - 2017-07-28 12:00 +0200
  [PATCH 1/3] dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 11:40 +0200
  Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Chen-Yu Tsai <wens@csie.org> - 2017-07-28 12:00 +0200
    Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 15:50 +0200
  Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 16:00 +0200
    Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 16:30 +0200
      Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 16:40 +0200
        Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-28 16:50 +0200
          Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:00 +0200
          Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 20:00 +0200
            Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-29 08:50 +0200
              Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-31 14:30 +0200
              Re: [PATCH 0/3] net-next: stmmac: support future possible different  internal phy mode Chen-Yu Tsai <wens@csie.org> - 2017-07-31 14:30 +0200

csiph-web