Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699512

[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Axel Lin <axel.lin@ingics.com>
Newsgroups linux.kernel
Subject [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices
Date Sun, 30 Jul 2017 13:00:01 +0200
Message-ID <u8U6Z-7Fp-3@gated-at.bofh.it> (permalink)
X-Original-To Lee Jones <lee.jones@linaro.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tiFriLd8QNwdH436WztiMQsyPNBcHosHvlASp5zC8CQ=; b=ruX16oohJWZ08KqId6qu71yH3NObeOmajMfBOtXqC4v1NdiesFRB+ftXeYa78nDSN0 ropMfUO70X/nxVPYwUdLBNu2fS7IpzdibnEqE+cc3ad0fwtT/jJb9MPECI1bBTEM/hze +lgpj8NTxL0Lsg55fAFuRd+WMw11lGUncilUxu1H9GaOmpyNgGNQGC1g/OpxDIaUgszD ILXpNWTcs3vzRRiHbcltxK7eZ78vT0d6hPYe3/cVtoYvf7uTNe2fEinBZy55+R9utDgV /WViw7ijsUrzorB74d2geWYpa4JOwPTXV7gzo3JpzIc7oOTNKghHchqV2W0YqONiF5Ad fEDQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tiFriLd8QNwdH436WztiMQsyPNBcHosHvlASp5zC8CQ=; b=FA4gkI54Ax4PPCrHHmlQa3uyqlnKQZBEqX+HoC7kQDGWaE5uOhQXl3AMswiXTv8g72 X8PtDSLN1r47y+j4bi9Bx3fOCOpYFeGgoBmCKz2MBprrcDT+GcBXOCSxsUXDpNmenE3K yFApMRfCCY2YTf4N/e35UJ7zZxAGk0oIc612k+35r5zu5NjkB9pOQMDBOnzSX1albY5j PV7VgsenZKlkZC6xvFim2ED+ghXOgUWX4svCJZzi9WkvhvbcD7uEpeXlDLB8/9t1J9j5 h2tIN2Yq5CQ0gf1eg/rdZAlA+X7O4Bd4qBh8Vy2F3ov71oL1kMJQWAbCX29/2LeVIKNi HS2w==
X-Gm-Message-State AIVw112pMRVnKrPpSWXtjxLWbKQHfsj9fD4AGEizu1apQEN6NG+Y+pfD IfbMYFe3DC4teuiT
X-Received by 10.98.202.73 with SMTP id n70mr12513546pfg.168.1501412307916; Sun, 30 Jul 2017 03:58:27 -0700 (PDT)
X-Mailer git-send-email 2.9.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc Keerthy <j-keerthy@ti.com>, linux-kernel@vger.kernel.org, Axel Lin <axel.lin@ingics.com>
X-Original-Date Sun, 30 Jul 2017 18:58:15 +0800
X-Original-Message-ID <20170730105815.26728-1-axel.lin@ingics.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1699512

Show key headers only | View raw


This fixes missing mfd_remove_devices() call when unload the module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mfd/lp87565.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 340ad0c..32d2a07 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
 
 	i2c_set_clientdata(client, lp87565);
 
-	ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
-			      ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
-
-	return ret;
+	return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
+				    lp87565_cells, ARRAY_SIZE(lp87565_cells),
+				    NULL, 0, NULL);
 }
 
 static const struct i2c_device_id lp87565_id_table[] = {
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin <axel.lin@ingics.com> - 2017-07-30 13:00 +0200
  Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Keerthy <j-keerthy@ti.com> - 2017-07-31 06:20 +0200
  Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:10 +0200

csiph-web