[PATCH 3/4] misc: tifm: constify pci_device_id.

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/4] misc: tifm: constify pci_device_id.
Date	2017-07-30 07:30 +0200
Message-ID	<u8OXE-4w5-15@gated-at.bofh.it> (permalink)
References	<u8OXD-4w5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

checkpatch ERROR: space prohibited before open square bracket '['

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/misc/tifm_7xx1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c
index a37a42f..e5f1087 100644
--- a/drivers/misc/tifm_7xx1.c
+++ b/drivers/misc/tifm_7xx1.c
@@ -415,7 +415,7 @@ static void tifm_7xx1_remove(struct pci_dev *dev)
 	tifm_free_adapter(fm);
 }
 
-static struct pci_device_id tifm_7xx1_pci_tbl [] = {
+static const struct pci_device_id tifm_7xx1_pci_tbl[] = {
 	{ PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_XX21_XX11_FM, PCI_ANY_ID,
 	  PCI_ANY_ID, 0, 0, 0 }, /* xx21 - the one I have */
         { PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_XX12_FM, PCI_ANY_ID,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] constify misc pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 2/4] misc: hpilo: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 1/4] misc: pch_phub: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 3/4] misc: tifm: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200

csiph-web