Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699415

[PATCH 2/4] misc: hpilo: constify pci_device_id.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/4] misc: hpilo: constify pci_device_id.
Date 2017-07-30 07:30 +0200
Message-ID <u8OXE-4w5-11@gated-at.bofh.it> (permalink)
References <u8OXD-4w5-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index fea8ff4..097e309 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -857,7 +857,7 @@ static int ilo_probe(struct pci_dev *pdev,
 	return error;
 }
 
-static struct pci_device_id ilo_devices[] = {
+static const struct pci_device_id ilo_devices[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_COMPAQ, 0xB204) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_HP, 0x3307) },
 	{ }
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] constify misc pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 2/4] misc: hpilo: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 1/4] misc: pch_phub: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200
  [PATCH 3/4] misc: tifm: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 07:30 +0200

csiph-web