Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters

From	Florian Westphal <fw@strlen.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters
Date	2017-07-29 23:30 +0200
Message-ID	<u8Ht8-7Zj-7@gated-at.bofh.it> (permalink)
References	<u8FUl-6S9-5@gated-at.bofh.it> <u8FUl-6S9-15@gated-at.bofh.it> <u8GdH-7fT-1@gated-at.bofh.it> <u8Gno-7k6-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Julia Lawall <julia.lawall@lip6.fr> wrote:
> > I think we can indeed constify these completely after making
> > 'nla_size' set at compile time.
> >
> > I'll send a simple attempt to make it so for l3proto soon.
> 
> There is another issue with respect to nf_ct_l3proto_unregister.  This
> calls nf_ct_iterate_destroy with l3proto as the second argument.  This
> function has signature:
> 
> void
> nf_ct_iterate_destroy(int (*iter)(struct nf_conn *i, void *data), void *data)
> 
> The void * is not const.  Maybe it could be.

Haven't looked if we can constify it in general, but, as the argument
is not going to be written to in this particular case it will not be
a showstopper.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] constify nf_conntrack_l3/4proto parameters Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 21:50 +0200
  [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 21:50 +0200
    Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters Florian Westphal <fw@strlen.de> - 2017-07-29 22:10 +0200
      Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto  parameters Julia Lawall <julia.lawall@lip6.fr> - 2017-07-29 22:20 +0200
        Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters Florian Westphal <fw@strlen.de> - 2017-07-29 23:30 +0200

csiph-web