Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support

From	Bart Van Assche <Bart.VanAssche@wdc.com>
Newsgroups	linux.kernel
Subject	Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support
Date	2017-07-29 23:30 +0200
Message-ID	<u8Ht8-7Zj-1@gated-at.bofh.it> (permalink)
References	<txklP-4zD-3@gated-at.bofh.it> <txklQ-4zD-7@gated-at.bofh.it> <u8g9B-627-23@gated-at.bofh.it> <u8G43-6WL-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-07-29 at 12:57 -0700, Dan Williams wrote:
> On Fri, Jul 28, 2017 at 9:17 AM, Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> > On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote:
> > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> > > index b7767da50c26..1de8372d9459 100644
> > > --- a/drivers/md/Kconfig
> > > +++ b/drivers/md/Kconfig
> > > @@ -200,6 +200,7 @@ config BLK_DEV_DM_BUILTIN
> > >  config BLK_DEV_DM
> > >       tristate "Device mapper support"
> > >       select BLK_DEV_DM_BUILTIN
> > > +     select DAX
> > >       ---help---
> > >         Device-mapper is a low level volume manager.  It works by allowing
> > >         people to specify mappings for ranges of logical sectors.  Various
> > 
> > (replying to an e-mail of three months ago)
> > 
> > Hello Dan,
> > 
> > While building a v4.12 kernel I noticed that enabling device mapper support
> > now unconditionally enables DAX. I think there are plenty of systems that use
> > dm but do not need DAX. Have you considered to rework this such that instead
> > of dm selecting DAX that DAX support is only enabled in dm if CONFIG_DAX is
> > enabled?
> 
> I'd rather flip this around and add a CONFIG_DM_DAX that gates whether
> DM enables / links to the DAX core. I'll take a look at a patch.

Thanks! Please also consider to move all DAX-related dm code into a separate
source file such that the number of #ifdef CONFIG_DM_DAX statements can be
kept to an absolute minimum.

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations  support Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-07-28 18:20 +0200
  Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations  support Mike Snitzer <snitzer@redhat.com> - 2017-07-28 19:50 +0200
  Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Dan Williams <dan.j.williams@intel.com> - 2017-07-29 22:00 +0200
    Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations  support Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-07-29 23:30 +0200

csiph-web