Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour
Date	2017-07-26 14:50 +0200
Message-ID	<u7tVf-mT-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <u7afT-4DI-3@gated-at.bofh.it> <u7qkF-6w4-3@gated-at.bofh.it> <u7qkF-6w4-1@gated-at.bofh.it> <u7tse-aO-9@gated-at.bofh.it> <u7tLz-jq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 26-07-17 14:33:57, Michal Hocko wrote:
> On Wed 26-07-17 13:11:46, Punit Agrawal wrote:
[...]
> > I've been running tests from mce-test suite and libhugetlbfs for similar
> > changes we did on arm64. There could be assumptions that were not
> > exercised but I'm not sure how to check for all the possible usages.
> > 
> > Do you have any other suggestions that can help improve confidence in
> > the patch?
> 
> Unfortunatelly I don't. I just know there were many subtle assumptions
> all over the place so I am rather careful to not touch the code unless
> really necessary.
> 
> That being said, I am not opposing your patch.

Let me be more specific. I am not opposing your patch but we should
definitely need more reviewers to have a look. I am not seeing any
immediate problems with it but I do not see a large improvements either
(slightly less nightmare doesn't make me sleep all that well ;)). So I
will leave the decisions to others.
-- 
Michal Hocko
SUSE Labs

Thread

[PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour Punit Agrawal <punit.agrawal@arm.com> - 2017-07-25 17:50 +0200
  Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Catalin Marinas <catalin.marinas@arm.com> - 2017-07-26 10:40 +0200
  Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Michal Hocko <mhocko@kernel.org> - 2017-07-26 11:00 +0200
    Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour Punit Agrawal <punit.agrawal@arm.com> - 2017-07-26 14:20 +0200
      Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Michal Hocko <mhocko@kernel.org> - 2017-07-26 14:40 +0200
        Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Michal Hocko <mhocko@kernel.org> - 2017-07-26 14:50 +0200
          Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour Punit Agrawal <punit.agrawal@arm.com> - 2017-07-26 15:40 +0200
            Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Mike Kravetz <mike.kravetz@oracle.com> - 2017-07-27 05:20 +0200
              Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour Punit Agrawal <punit.agrawal@arm.com> - 2017-07-27 15:00 +0200
  Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and  document behaviour Michal Hocko <mhocko@kernel.org> - 2017-07-26 11:00 +0200

csiph-web