Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1696629

[PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died

Show all headers | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Make usb_hc_died() clear the HCD_FLAG_RH_RUNNING flag for the shared
HCD and set HCD_FLAG_DEAD for it, in analogy with what is done for
the primary one.

Among other thigs, this prevents check_root_hub_suspended() from
returning -EBUSY for dead HCDs which helps to work around system
suspend issues in some situations.

This actually fixes occasional suspend failures on one of my test
machines.

Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/usb/core/hcd.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-pm/drivers/usb/core/hcd.c
===================================================================
--- linux-pm.orig/drivers/usb/core/hcd.c
+++ linux-pm/drivers/usb/core/hcd.c
@@ -2485,6 +2485,8 @@ void usb_hc_died (struct usb_hcd *hcd)
 	}
 	if (usb_hcd_is_primary_hcd(hcd) && hcd->shared_hcd) {
 		hcd = hcd->shared_hcd;
+		clear_bit(HCD_FLAG_RH_RUNNING, &hcd->flags);
+		set_bit(HCD_FLAG_DEAD, &hcd->flags);
 		if (hcd->rh_registered) {
 			clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 01:20 +0200
  Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for  HCD_DEAD() Alan Stern <stern@rowland.harvard.edu> - 2017-07-25 16:10 +0200
    Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 18:10 +0200
      Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 22:50 +0200
        Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for  HCD_DEAD() Alan Stern <stern@rowland.harvard.edu> - 2017-07-25 23:10 +0200
          Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 23:50 +0200
  [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 00:10 +0200
    Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one  died Alan Stern <stern@rowland.harvard.edu> - 2017-07-26 16:30 +0200
      Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 19:20 +0200
        Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one  died Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-30 19:10 +0200

csiph-web