Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695259

[PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD()

Show all headers | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

If HCD_DEAD(hcd) is "true" in check_root_hub_suspended(), it is
rather pointless to check the secondary root hub, so return early
then.

This actually fixes occasional suspend failures on one of my test
machines.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/usb/core/hcd-pci.c |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-pm/drivers/usb/core/hcd-pci.c
===================================================================
--- linux-pm.orig/drivers/usb/core/hcd-pci.c
+++ linux-pm/drivers/usb/core/hcd-pci.c
@@ -427,6 +427,9 @@ static int check_root_hub_suspended(stru
 		dev_warn(dev, "Root hub is not suspended\n");
 		return -EBUSY;
 	}
+	if (HCD_DEAD(hcd))
+		return 0;
+
 	if (hcd->shared_hcd) {
 		hcd = hcd->shared_hcd;
 		if (HCD_RH_RUNNING(hcd)) {

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 01:20 +0200
  Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for  HCD_DEAD() Alan Stern <stern@rowland.harvard.edu> - 2017-07-25 16:10 +0200
    Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 18:10 +0200
      Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 22:50 +0200
        Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for  HCD_DEAD() Alan Stern <stern@rowland.harvard.edu> - 2017-07-25 23:10 +0200
          Re: [PATCH] PM / USB: hcd_pci: Skip secondary root hub check for HCD_DEAD() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-25 23:50 +0200
  [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 00:10 +0200
    Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one  died Alan Stern <stern@rowland.harvard.edu> - 2017-07-26 16:30 +0200
      Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one died "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-07-26 19:20 +0200
        Re: [PATCH] USB: hcd: Mark secondary HCD as dead if the primary one  died Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-30 19:10 +0200

csiph-web