[PATCH] netpoll: Fix device name check in netpoll_setup()

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] netpoll: Fix device name check in netpoll_setup()
Date	2017-07-25 20:40 +0200
Message-ID	<u7cUp-6m2-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer
when checking if the device name is set:

if (np->dev_name) {
  ...

However the field is a character array, therefore the condition always
yields true. Check instead whether the first byte of the array has a
non-zero value.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 net/core/netpoll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 8357f164c660..912731bed7b7 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -666,7 +666,7 @@ int netpoll_setup(struct netpoll *np)
 	int err;
 
 	rtnl_lock();
-	if (np->dev_name) {
+	if (np->dev_name[0]) {
 		struct net *net = current->nsproxy->net_ns;
 		ndev = __dev_get_by_name(net, np->dev_name);
 	}
-- 
2.14.0.rc0.284.gd933b75aa4-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] netpoll: Fix device name check in netpoll_setup() Matthias Kaehlcke <mka@chromium.org> - 2017-07-25 20:40 +0200
  Re: [PATCH] netpoll: Fix device name check in netpoll_setup() Doug Anderson <dianders@chromium.org> - 2017-07-26 21:00 +0200
    Re: [PATCH] netpoll: Fix device name check in netpoll_setup() Cong Wang <xiyou.wangcong@gmail.com> - 2017-07-26 23:00 +0200
  Re: [PATCH] netpoll: Fix device name check in netpoll_setup() David Miller <davem@davemloft.net> - 2017-07-27 02:10 +0200

csiph-web