Re: [PATCH] netpoll: Fix device name check in netpoll_setup()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netpoll: Fix device name check in netpoll_setup()
Date	2017-07-27 02:10 +0200
Message-ID	<u7Exj-7hl-3@gated-at.bofh.it> (permalink)
References	<u7cUp-6m2-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Matthias Kaehlcke <mka@chromium.org>
Date: Tue, 25 Jul 2017 11:36:25 -0700

> Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer
> when checking if the device name is set:
> 
> if (np->dev_name) {
>   ...
> 
> However the field is a character array, therefore the condition always
> yields true. Check instead whether the first byte of the array has a
> non-zero value.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

Applied, thanks a lot.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netpoll: Fix device name check in netpoll_setup() Matthias Kaehlcke <mka@chromium.org> - 2017-07-25 20:40 +0200
  Re: [PATCH] netpoll: Fix device name check in netpoll_setup() Doug Anderson <dianders@chromium.org> - 2017-07-26 21:00 +0200
    Re: [PATCH] netpoll: Fix device name check in netpoll_setup() Cong Wang <xiyou.wangcong@gmail.com> - 2017-07-26 23:00 +0200
  Re: [PATCH] netpoll: Fix device name check in netpoll_setup() David Miller <davem@davemloft.net> - 2017-07-27 02:10 +0200

csiph-web