Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695933

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

Show all headers | View raw

On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The sriov_lock is used to serialize the sriov code with the vfr code.
> However, when SRIOV is disabled, the lock is not there at all, leading
> to a build error:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function 'bnxt_dl_eswitch_mode_set':
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:410:16: error: 'struct bnxt' has no member named 'sriov_lock'
>
> We can either provide the mutex in this configuration, too, or
> disable both SRIOV and VFR together. This implements the first
> approach, since it seems like a reasonable configuration for
> guest kernels to have, and the extra lock will be harmless when
> there is no contention.
>
> Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Sathya already sent 3 patches to fix some of these issues.  But I need
to rework one of his patch and resend.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] bnxt_en: add CONFIG_NET_SWITCHDEV dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:40 +0200
  [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:40 +0200
    Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Michael Chan <michael.chan@broadcom.com> - 2017-07-25 18:40 +0200
      Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-26 11:10 +0200
        Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Sathya Perla <sathya.perla@broadcom.com> - 2017-07-26 13:00 +0200
          Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-26 15:20 +0200
            Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-27 09:50 +0200
              Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Sathya Perla <sathya.perla@broadcom.com> - 2017-07-27 11:10 +0200
                Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-27 12:00 +0200

csiph-web