Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

From	Sathya Perla <sathya.perla@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally
Date	2017-07-27 11:10 +0200
Message-ID	<u7MXV-4d2-41@gated-at.bofh.it> (permalink)
References	(2 earlier) <u7b2h-59O-3@gated-at.bofh.it> <u7qun-6OE-27@gated-at.bofh.it> <u7scO-7G7-3@gated-at.bofh.it> <u7uoi-LY-11@gated-at.bofh.it> <u7LIu-3gV-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann <arnd@arndb.de> wrote:
[...]
>
> On today's linux-next:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register':
> bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc'
> bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink_register'
> bnxt_vfr.c:(.text+0x14e0): undefined reference to `devlink_free'
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_unregister':
> bnxt_vfr.c:(.text+0x1534): undefined reference to `devlink_unregister'
> bnxt_vfr.c:(.text+0x153c): undefined reference to `devlink_free'
>
> I think you are just missing a "depends on MAY_USE_DEVLINK"
> in INFINIBAND_BNXT_RE, which uses 'select BNXT'.
>
> This is a tricky corner case for Kconfig, where the MAY_USE_DEVLINK
> dependency is silently ignored for BNXT as long as MAY_USE_DEVLINK
> is not "=n".

Can you pls share your .config so that I can reproduce this issue and
ensure that my fix really works...

Thread

[PATCH net-next 1/2] bnxt_en: add CONFIG_NET_SWITCHDEV dependency Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:40 +0200
  [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-25 17:40 +0200
    Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Michael Chan <michael.chan@broadcom.com> - 2017-07-25 18:40 +0200
      Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-26 11:10 +0200
        Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Sathya Perla <sathya.perla@broadcom.com> - 2017-07-26 13:00 +0200
          Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-26 15:20 +0200
            Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-27 09:50 +0200
              Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Sathya Perla <sathya.perla@broadcom.com> - 2017-07-27 11:10 +0200
                Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally Arnd Bergmann <arnd@arndb.de> - 2017-07-27 12:00 +0200

csiph-web