RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active
Date	2017-07-27 09:50 +0200
Message-ID	<u7LIt-3gV-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <u74Nb-1aa-3@gated-at.bofh.it> <u7s38-7CE-23@gated-at.bofh.it> <u7AtI-4y2-19@gated-at.bofh.it> <u7AtI-4y2-17@gated-at.bofh.it> <u7LIu-3gV-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Brijesh Singh
> Sent: 26 July 2017 21:07
...
> I am not sure if I understand your concern.
> 
> Are you commenting on amount of code duplication ? If so, I can certainly improve
> and use the similar macro used into header file to generate the functions body.

If you are careful the real functions could expand the inline functions
that get used when SEV is compiled out.

Oh, if you are looking at this, can you fix memcpy_to_io()
so that it is never 'rep movsb'?

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV  is active David Laight <David.Laight@ACULAB.COM> - 2017-07-25 12:00 +0200
  Re: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active Arnd Bergmann <arnd@arndb.de> - 2017-07-26 12:50 +0200
    Re: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active "H. Peter Anvin" <hpa@zytor.com> - 2017-07-26 21:50 +0200
      RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV  is active David Laight <David.Laight@ACULAB.COM> - 2017-07-27 09:50 +0200

csiph-web