Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695554

RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active

Show all headers | View raw

From: Brijesh Singh
> Sent: 24 July 2017 20:08
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> Secure Encrypted Virtualization (SEV) does not support string I/O, so
> unroll the string I/O operation into a loop operating on one element at
> a time.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>  arch/x86/include/asm/io.h | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
> index e080a39..2f3c002 100644
> --- a/arch/x86/include/asm/io.h
> +++ b/arch/x86/include/asm/io.h
> @@ -327,14 +327,32 @@ static inline unsigned type in##bwl##_p(int port)			\
>  									\
>  static inline void outs##bwl(int port, const void *addr, unsigned long count) \
>  {

Is it even worth leaving these as inline functions?
Given the speed of IO cycles it is unlikely that the cost of calling a real
function will be significant.
The code bloat reduction will be significant.

	David

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV  is active David Laight <David.Laight@ACULAB.COM> - 2017-07-25 12:00 +0200
  Re: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active Arnd Bergmann <arnd@arndb.de> - 2017-07-26 12:50 +0200
    Re: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV is active "H. Peter Anvin" <hpa@zytor.com> - 2017-07-26 21:50 +0200
      RE: [RFC Part1 PATCH v3 13/17] x86/io: Unroll string I/O when SEV  is active David Laight <David.Laight@ACULAB.COM> - 2017-07-27 09:50 +0200

csiph-web